Tech Leaders Pride #614
Merged
ChrisLovering merged 15 commits intoJun 4, 2021
Merged
Conversation
Xithrius
added
area: backend
Kronifer
reviewed
Mar 11, 2021
Contributor
Kronifer
left a comment
Kronifer
left a comment
There was a problem hiding this comment.
Looks good so far, will review once at a computer and can test
RohanJnr
reviewed
Mar 13, 2021
RohanJnr
reviewed
Mar 13, 2021
RohanJnr
approved these changes
Mar 13, 2021
Contributor
RohanJnr
left a comment
RohanJnr
left a comment
There was a problem hiding this comment.
Apart from the minor changes mentioned above, everything else looks good and tested!
anand2312
suggested changes
Apr 29, 2021
The entire `name_verifier` function can be replaced with just a dict.get
ToxicKidz
suggested changes
May 18, 2021
* Use read_text rather a with open * Remove Redundant list comprehension
Co-authored-by: ToxicKidz <78174417+ToxicKidz@users.noreply.github.com>
Xithrius
reviewed
Jun 3, 2021
kosayoda
suggested changes
Jun 3, 2021
Contributor
kosayoda
left a comment
kosayoda
left a comment
There was a problem hiding this comment.
The command does not work correctly when given a pride leader. Example: .pl Alan Joyce.
Additionally, I don't think the error embed should the wiki info for an unavailable leader. Perhaps a message saying to contribute to the list instead?
Neat work otherwise.
kosayoda
suggested changes
Jun 3, 2021
ToxicKidz
approved these changes
Jun 4, 2021
ChrisLovering
approved these changes
Jun 4, 2021
Xithrius
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #208
Continuation #485
Description
Adds a command
.prideleaderwhich will give a pretty embed containing information given in aresources/pride/prideleader.json. It also links to the wikipedia command for that particular Pride Leader so that the user can get some more information on that. In case of Pride Leader not contained in the resources, it will add it to thehackbot.logwith levelTRACEand give link to the wikipedia command for that Pride Leader.Reasoning
Approved by a staff member.
Screenshots
Tim Cook
Error Embed
Did you:
pipenv run lint)?