Skip to content

Embed fix in earth_photos#621

Merged
Xithrius merged 4 commits into
python-discord:masterfrom
Kronifer:earth_photos
Mar 10, 2021
Merged

Embed fix in earth_photos#621
Xithrius merged 4 commits into
python-discord:masterfrom
Kronifer:earth_photos

Conversation

@Kronifer
Copy link
Copy Markdown
Contributor

@Kronifer Kronifer commented Mar 9, 2021

Relevant Issues

Fixes a small visual bug on mobile in the .earth_photos command

Description

Made a change suggested by ToxicKidz on discord shown here

Reasoning

The bug was annoying

Screenshots

Before fix:
Screenshot_20210309-170341_Discord
After fix:
Screenshot_20210309-170316_Discord

Did you:

  • Join the Python Discord Community?
  • [didnt change] If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@Xithrius Xithrius added area: backend Related to internal functionality and utilities season: evergreen status: needs review Author is waiting for someone to review and approve type: bug Something isn't working labels Mar 10, 2021
@Xithrius Xithrius requested a review from ChrisLovering March 10, 2021 03:37
Comment thread bot/exts/easter/earth_photos.py Outdated
Co-authored-by: Shivansh-007 <69356296+Shivansh-007@users.noreply.github.com>
@Kronifer
Copy link
Copy Markdown
Contributor Author

oop mentioned wrong person there in 3939fa7

Copy link
Copy Markdown
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Kronifer
Copy link
Copy Markdown
Contributor Author

@Xithrius could you review

@Kronifer
Copy link
Copy Markdown
Contributor Author

Oops sorry Chris, hit the wrong thing

@Xithrius Xithrius merged commit 1d3860d into python-discord:master Mar 10, 2021
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants