Fixed Battleship game ends abruptly if given bad input #622#674
Merged
Conversation
Update battleship.py
Contributor
|
@rijusougata13 Thanks for your contribution! Please fill pull request template fully and give why and what you changed. Thanks. |
rijusougata13
changed the title
Contributor
Author
|
@ks129 is it okay now? |
Contributor
Author
|
so then we can merge and close the issue |
ChrisLovering
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #622
Description
self.match = re.fullmatch("([A-J]|[a-j]) ?((10)|[1-9])", message.content.strip())
I changed the regular expression match to full match .
Reasoning
Basically pattern.match will return if any prefix of that pattern matches.
pattern.fullmatch will return true when the whole string matches
Screenshots
Additional Details
Did you:
pipenv lock?pipenv run lint)?