Skip to content

Fixed the .catify command producing UnboundLocal and Forbidden Errors#697

Merged
janine9vn merged 4 commits into
python-discord:mainfrom
ToxicKidz:fix_catify
Apr 21, 2021
Merged

Fixed the .catify command producing UnboundLocal and Forbidden Errors#697
janine9vn merged 4 commits into
python-discord:mainfrom
ToxicKidz:fix_catify

Conversation

@ToxicKidz
Copy link
Copy Markdown
Contributor

Description

I indented some code into the else statement because some variables that were defined in it were used outside of it, and suppressed discord.Forbidden when someone with a higher role than Sir Lancebot uses the command.

Did you:

  • Join the Python Discord Community?
  • If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@jb3 jb3 mentioned this pull request Apr 20, 2021
4 tasks
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Copy Markdown
Contributor

@Kronifer Kronifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! :shipit:

Copy link
Copy Markdown
Contributor

@purefunctor purefunctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@janine9vn janine9vn merged commit 38c5d61 into python-discord:main Apr 21, 2021
@ToxicKidz ToxicKidz deleted the fix_catify branch April 21, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants