Skip to content

More topics to start Python-related conversations with.#792

Merged
ChrisLovering merged 1 commit into
mainfrom
more-py-topics
Aug 16, 2021
Merged

More topics to start Python-related conversations with.#792
ChrisLovering merged 1 commit into
mainfrom
more-py-topics

Conversation

@Xithrius
Copy link
Copy Markdown
Contributor

Continuation of #763.

@Xithrius Xithrius added category: evergreen area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features labels Jul 31, 2021
@Xithrius Xithrius requested review from eivl, janine9vn and kosayoda July 31, 2021 10:07
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just grammar and wording. There are a couple of pythons that should be Pythons I didn't comment on. Could you also fix capitalization on line 19, as PyPi, should be PyPI. Not part of this PR but probably not worth it's own one ig.

Comment thread bot/resources/evergreen/py_topics.yaml Outdated
Comment thread bot/resources/evergreen/py_topics.yaml Outdated
Comment thread bot/resources/evergreen/py_topics.yaml Outdated
Comment thread bot/resources/evergreen/py_topics.yaml
Comment thread bot/resources/evergreen/py_topics.yaml Outdated
Comment thread bot/resources/evergreen/py_topics.yaml Outdated
@wookie184 wookie184 mentioned this pull request Aug 2, 2021
2 tasks
@Xithrius Xithrius requested a review from wookie184 August 2, 2021 21:42
@Xithrius
Copy link
Copy Markdown
Contributor Author

Xithrius commented Aug 2, 2021

The syntax has changed for the yaml file, given the : near the end of it. I think I need to escape that with one singular \.

@wookie184
Copy link
Copy Markdown
Contributor

wookie184 commented Aug 2, 2021

Oh interesting, that makes sense. (googling it, i'm not sure if a backslash is correct but i'm not 100% sure https://stackoverflow.com/questions/11301650/how-to-escape-indicator-characters-i-e-or-in-yaml, haven't use yaml personally)

Also still some pythons that need capitalizing btw

@NIRDERIi
Copy link
Copy Markdown
Contributor

NIRDERIi commented Aug 2, 2021

I wish I could help with the Python caps, but it'll be a lot of trouble to start a new fork for it

@NIRDERIi
Copy link
Copy Markdown
Contributor

NIRDERIi commented Aug 3, 2021

Caps issue:
Line: 26. Word: python -> Python. Reason: Name
Line 31. Word: python -> Python Reason: Name
Line 32. Word: python -> Python Reason: Name
Line 33. Word: python -> Python Reason: Name
Line 35. Word: python -> Python Reason: Name
Line 67. Word: what -> What. Reason: After question mark (?)

Copy link
Copy Markdown
Contributor

@brad90four brad90four left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a consistent rule for capitalized or un-capitalized "python"?
Lines 26, 31, 32, 33, 35 are un-capitalized, but the others are capitalized.

For line 36, The wording seems a bit clunky. Maybe "What Python level/skill/knowledge do you think you are at: Beginner, Intermediate or Advanced?"

(Just chiming in, wanting to get started with contributing!)

@NIRDERIi
Copy link
Copy Markdown
Contributor

NIRDERIi commented Aug 4, 2021

Wdym? They are not capitalized which is incorrect spelling, the others are capitalized because it is the correct spelling because it is a name. Unless I misunderstood you?

Comment thread bot/resources/evergreen/py_topics.yaml Outdated
@brad90four
Copy link
Copy Markdown
Contributor

brad90four commented Aug 4, 2021

Wdym? They are not capitalized which is incorrect spelling, the others are capitalized because it is the correct spelling because it is a name. Unless I misunderstood you?

I was just unsure if there was some un-written rule of when to use "python" vs "Python". For example I could say I have a python script written in Python. When it is an adjective lower case seems fine, but as a noun it seems more proper to use the capitalization. Also, saying "x is more pythonic" looks more appropriate thatn "x looks more Pythonic."

Comment thread bot/resources/evergreen/py_topics.yaml Outdated
Comment thread bot/resources/evergreen/py_topics.yaml Outdated
@Xithrius
Copy link
Copy Markdown
Contributor Author

Xithrius commented Aug 8, 2021

@NIRDERIi @Shivansh-007 @wookie184 fixed stuff up.

@NIRDERIi
Copy link
Copy Markdown
Contributor

NIRDERIi commented Aug 8, 2021

Looks great for me!

@Xithrius Xithrius requested review from Den4200 and whispersofthedawn and removed request for eivl and kosayoda August 16, 2021 04:14
Copy link
Copy Markdown

@whispersofthedawn whispersofthedawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ChrisLovering ChrisLovering merged commit d7a688c into main Aug 16, 2021
@ChrisLovering ChrisLovering deleted the more-py-topics branch August 16, 2021 20:26
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities type: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants