Fix type annotations by decorator-factory · Pull Request #802 · python-discord/sir-lancebot

decorator-factory · 2021-08-07T02:26:40Z

This PR aims to improve type annotations (type hints) in the project:

change old-style annotations (like typing.List[int]) to new-style annotations (like list[int])
fix annotations that are just wrong

kwzrd

Looks good, I think I only caught 1 or 2 things that could mistakes, but you be the judge of that.

I approach this as a PR that intends to make better use of PEP 585. Therefore I was mostly looking for regression; I haven't verified that all existing hints are correct.

kwzrd

Looks LGTM to me, good changes overall.

The notion of imposing better validation on data coming from external sources is attractive, though on the other hand Lancebot is primarily aimed at beginners. I don't know whether it'd make sense to put in the effort of making existing features more resilient if the same level of resilience isn't required from new contributions.

decorator-factory · 2021-08-08T15:37:46Z

I think it's a good idea to teach beginners about validation, security and all that stuff. Lancebot being a learning project, we want to teach people good practices. Besides, the bot is running on our hardware and has access to some of our secrets, so we wouldn't want to introduce vulnerabilities (#801)

Xithrius · 2021-08-22T08:56:26Z

I will be continuing this PR, as @decorator-factory authorized.

ventaquil

Can some explain why sometimes it's import typing, sometimes it's from typing import ... and even sometimes it's import typing as t? 🤔

brad90four

LGTM. That was a lot of different files to go through!

Xithrius · 2021-08-27T20:10:10Z

I'll be getting this done soon, currently having IRL stuff.

Xithrius · 2021-08-30T09:57:35Z

I intend to start working on this within the next 24 hours.

Xithrius · 2021-08-31T00:26:03Z

I will be squashing this PR when it's done.

MarkKoz

bot/exts/__init__.py should import Iterator from collections.abc instead.
bot/utils/extensions.py should import Iterator from collections.abc instead.

Den4200

Just a few minor things.

MrHemlock

Everything looks solid. I didn't see anything missed.

jonathan-d-zhang

lgtm, but why

fisher60

looks pretty good to me I think

Xithrius · 2021-09-02T19:46:02Z

I didn't squash, sorry about that.

decorator-factory mentioned this pull request Aug 7, 2021

Type annotation improvements #803

Closed

2 tasks

kwzrd reviewed Aug 7, 2021

View reviewed changes

Comment thread bot/exts/evergreen/snakes/_utils.py

Comment thread bot/exts/evergreen/snakes/_utils.py Outdated

Comment thread bot/exts/evergreen/snakes/_utils.py

Comment thread bot/exts/evergreen/movie.py Outdated

Comment thread bot/exts/evergreen/wolfram.py

kwzrd approved these changes Aug 8, 2021

View reviewed changes

decorator-factory marked this pull request as ready for review August 8, 2021 15:32

decorator-factory requested a review from ks129 as a code owner August 8, 2021 15:32

MarkKoz reviewed Aug 8, 2021

View reviewed changes

Comment thread bot/exts/evergreen/snakes/_converter.py Outdated

Xithrius added area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features labels Aug 16, 2021

Xithrius requested review from SebastiaanZ and ToxicKidz August 16, 2021 04:15

Xithrius self-assigned this Aug 22, 2021

Xithrius added status: WIP Work In Progress and removed status: needs review Author is waiting for someone to review and approve labels Aug 22, 2021

ventaquil reviewed Aug 24, 2021

View reviewed changes

Comment thread bot/exts/easter/bunny_name_generator.py Outdated

Comment thread bot/exts/christmas/advent_of_code/_helpers.py Outdated

Comment thread bot/exts/evergreen/fun.py Outdated

brad90four approved these changes Aug 27, 2021

View reviewed changes

ventaquil suggested changes Aug 28, 2021

View reviewed changes

Xithrius removed the status: WIP Work In Progress label Aug 30, 2021

Xithrius requested review from MarkKoz, jb3 and ventaquil August 31, 2021 00:55

MarkKoz requested changes Aug 31, 2021

View reviewed changes

Comment thread bot/utils/checks.py Outdated

Comment thread bot/exts/utils/extensions.py Outdated

Comment thread bot/utils/decorators.py Outdated

Comment thread bot/utils/randomization.py Outdated

MarkKoz reviewed Aug 31, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wolfram.py Outdated

Fix type annotations

745cd1d

Xithrius force-pushed the decorator-factory/typehints-fix branch from 55ecb2a to 745cd1d Compare August 31, 2021 20:09

ventaquil suggested changes Sep 1, 2021

View reviewed changes

Comment thread bot/utils/decorators.py Outdated

Comment thread bot/utils/decorators.py Outdated

Comment thread bot/utils/decorators.py Outdated

Comment thread bot/utils/randomization.py Outdated

Comment thread bot/exts/internal_eval/_helpers.py

Den4200 requested changes Sep 1, 2021

View reviewed changes

Comment thread bot/exts/evergreen/coinflip.py Outdated

Comment thread bot/exts/evergreen/wikipedia.py Outdated

ventaquil reviewed Sep 1, 2021

View reviewed changes

Comment thread bot/exts/easter/bunny_name_generator.py

Xithrius added 3 commits September 1, 2021 18:32

Union item with None to Optional with item.

f4e5e38

Removed None return annotation for any __init__

aecc1e6

Removed unecessary annotations.

d2532bc

Xithrius requested review from Den4200 and ventaquil September 2, 2021 01:51

Bluenix2 reviewed Sep 2, 2021

View reviewed changes

Comment thread bot/exts/christmas/advent_of_code/_cog.py

Comment thread bot/exts/evergreen/battleship.py Outdated

Comment thread bot/exts/evergreen/snakes/_utils.py

Comment thread bot/exts/evergreen/wolfram.py Outdated

Comment thread bot/utils/randomization.py

ventaquil suggested changes Sep 2, 2021

View reviewed changes

Comment thread bot/exts/evergreen/connect_four.py Outdated

Den4200 approved these changes Sep 2, 2021

View reviewed changes

Xithrius added 3 commits September 2, 2021 10:10

Removed depricated typing.Match

36a0589

Added documentation for tuple

ba6a28d

Removed unecessary None annotation

3a72199

Xithrius requested review from Bluenix2 and ventaquil September 2, 2021 17:14

MrHemlock approved these changes Sep 2, 2021

View reviewed changes

Xithrius added 3 commits September 2, 2021 11:32

Removed more not-needed None returns

d9951be

A list of emojis

aee91b5

More explicit importing for Bot

9ce33f3

Xithrius requested a review from fisher60 September 2, 2021 18:55

fisher60 reviewed Sep 2, 2021

View reviewed changes

Comment thread bot/exts/christmas/advent_of_code/_helpers.py

jonathan-d-zhang approved these changes Sep 2, 2021

View reviewed changes

Merge branch 'main' into decorator-factory/typehints-fix

02e620d

fisher60 approved these changes Sep 2, 2021

View reviewed changes

Xithrius merged commit 8813045 into main Sep 2, 2021

Xithrius deleted the decorator-factory/typehints-fix branch September 2, 2021 19:42

Bluenix2 mentioned this pull request Sep 8, 2021

Add WTF Python Command #859

Merged

4 tasks

TizzySaurus mentioned this pull request Dec 23, 2021

Add Twemoji utility command #988

Merged

4 tasks

Uh oh!

Conversation

decorator-factory commented Aug 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwzrd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kwzrd left a comment

Choose a reason for hiding this comment

Uh oh!

decorator-factory commented Aug 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Xithrius commented Aug 22, 2021

Uh oh!

ventaquil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brad90four left a comment

Choose a reason for hiding this comment

Uh oh!

Xithrius commented Aug 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Xithrius commented Aug 30, 2021

Uh oh!

Xithrius commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarkKoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Den4200 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrHemlock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonathan-d-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

decorator-factory commented Aug 7, 2021 •

edited

Loading

decorator-factory commented Aug 8, 2021 •

edited

Loading

Xithrius commented Aug 31, 2021 •

edited

Loading