Love command checks#806
Merged
Merged
Conversation
This ensure the valentines themed command can only be ran during the valentines season.
This ensure that only uses that have opted into the love fest event can actually be used as part of this command.
This ensures the same result for same input, regardless of order
Since we update how the command behaves, by not allow arbitrary stings, and being symmetrical, we should reflect this in the docstring.
Now that we don't allow arbitrary strings, we can simplify the input validation/modification we do.
Akarys42
previously requested changes
Aug 10, 2021
…check fails Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>
wookie184
reviewed
Aug 12, 2021
wookie184
requested changes
Aug 12, 2021
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Could add a footer to the embed sent saying you can unsubscribe with .lovefest unsub, but you could also not do that, I don't' mind.
ChrisLovering
force-pushed
the
love-command-checks
branch
from
74f0e91 to
9542ec7
Compare
This skips the role check if the author is running the love calc command on themselves. We still want to check the the user running against has the role, along with if the author is running it against 2 other people. i have also included info on how to get the lovefest role in the error embed.
ChrisLovering
force-pushed
the
love-command-checks
branch
from
9542ec7 to
446c86f
Compare
ChrisLovering
added
the
status: needs review
Xithrius
added
area: backend
Xithrius
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes a few changes to the
.lovecommand to make it slightly less creepy, more consistent with other lovefest commands and also makes it give consistent output, regardless of input order.The changes I have made are:
in_monthcheck, to ensure the command can only run during February (valentine season)Did you: