.quack#849
Merged
Merged
Conversation
wookie184
previously requested changes
Sep 5, 2021
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
All works well, just some minor comments on a few things. Thanks for the PR!
wookie184
reviewed
Sep 5, 2021
Xithrius
added
area: backend
doublevcodes
reviewed
Sep 5, 2021
Contributor
doublevcodes
left a comment
doublevcodes
left a comment
There was a problem hiding this comment.
None of this is solid stuff that needs to necessarily happen, just a few pointers.
Bluenix2
reviewed
Sep 5, 2021
Bluenix2
reviewed
Sep 6, 2021
Xithrius
added
category: fun
Shom770
reviewed
Sep 6, 2021
Contributor
Shom770
left a comment
Shom770
left a comment
There was a problem hiding this comment.
I love this command! It's pretty neat and it would be nice to have the Quackstack command exist in Python Discord itself! I have a few nitpicks here and there, but otherwise, style-wise, this looks good!
Xithrius
requested changes
Sep 7, 2021
brad90four
reviewed
Sep 7, 2021
Bluenix2
reviewed
Sep 7, 2021
Bluenix2
reviewed
Sep 8, 2021
Bluenix2
reviewed
Sep 9, 2021
D0rs4n
suggested changes
Sep 13, 2021
Bluenix2
reviewed
Sep 18, 2021
Bluenix2
reviewed
Sep 18, 2021
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Bluenix2
reviewed
Sep 22, 2021
Bluenix2
approved these changes
Sep 30, 2021
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
Thanks for this Kronifier!
Xithrius
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #652
Description
Implemented a
.quackcommand that can take a seed and optional ducky type if you want to generate a duck or manduck. If the seed given is a word, that word is converted into a seed by converting the string bytes to an integerDid you: