Skip to content

Added Hanukka command in November month.#864

Merged
Xithrius merged 1 commit into
python-discord:mainfrom
NIRDERIi:hanukkah_cmd_month
Sep 9, 2021
Merged

Added Hanukka command in November month.#864
Xithrius merged 1 commit into
python-discord:mainfrom
NIRDERIi:hanukkah_cmd_month

Conversation

@NIRDERIi
Copy link
Copy Markdown
Contributor

@NIRDERIi NIRDERIi commented Sep 8, 2021

This is a solution for the #862 issue, which says the Hanukka holiday can also be in November and not only in December.

Relevant Issues

Closes #862

Description

I added the Hanukka command in November month, by adding Month.NOVEMBER to the in_month decorator.

Did you:

This is a solution for the python-discord#862 issue, which says the Hanukka holiday can also be in November and not only in December.
Copy link
Copy Markdown
Contributor

@brad90four brad90four left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although my reviews don't count :p

Copy link
Copy Markdown
Contributor

@D0rs4n D0rs4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link
Copy Markdown
Contributor

@Kronifer Kronifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Xithrius Xithrius added area: backend Related to internal functionality and utilities category: holidays Related to holidays (Christmas, Halloween, Valentine's) type: enhancement Changes or improvements to existing features labels Sep 9, 2021
@Xithrius Xithrius merged commit cc29983 into python-discord:main Sep 9, 2021
@NIRDERIi NIRDERIi deleted the hanukkah_cmd_month branch September 9, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities category: holidays Related to holidays (Christmas, Halloween, Valentine's) type: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.hanukkah should not be timelocked to December

6 participants