Skip to content

added a .gitpod.yml#867

Merged
ChrisLovering merged 13 commits into
python-discord:mainfrom
Kronifer:gitpod
Sep 24, 2021
Merged

added a .gitpod.yml#867
ChrisLovering merged 13 commits into
python-discord:mainfrom
Kronifer:gitpod

Conversation

@Kronifer
Copy link
Copy Markdown
Contributor

@Kronifer Kronifer commented Sep 14, 2021

Relevant Issues

Closes #611

Description

Adds a .gitpod.yml file that automatically installs Python 3.9.6, poetry and installs poetry dependencies.

Did you:

@Kronifer Kronifer marked this pull request as draft September 14, 2021 00:48
@Kronifer Kronifer marked this pull request as ready for review September 14, 2021 00:55
@onerandomusername
Copy link
Copy Markdown
Contributor

onerandomusername commented Sep 14, 2021

Hi, given the changes that this makes, I believe policy is to squash them into one commit.
View https://pythondiscord.notion.site/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa for how to do that.

@Kronifer
Copy link
Copy Markdown
Contributor Author

Kronifer commented Sep 14, 2021

Hi, given the changes that this makes, I believe policy is to squash them into one commit.
View https://pythondiscord.notion.site/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa for how to do that.

squashed

Bluenix2
Bluenix2 reviewed Sep 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking at several tutorials and Gitpods reference itself, and this looks pretty good. Just have a few questions

Comment thread .gitpod.yml Outdated
Comment thread .gitpod.yml Outdated
@onerandomusername
Copy link
Copy Markdown
Contributor

onerandomusername commented Sep 14, 2021 via email

@Kronifer
Copy link
Copy Markdown
Contributor Author

Kronifer commented Sep 14, 2021

@onerandomusername I'll work on that later

@Kronifer @Bluenix2
Update .gitpod.yml
e0d0410 
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Bluenix2
Bluenix2 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it clear that I do not have Gitpod and cannot test this, but this all looks good according to all documentation I could find.

Bluenix2
Bluenix2 reviewed Sep 15, 2021
View reviewed changes
Comment thread .gitpod.yml Outdated
@Xithrius Xithrius added area: dependencies Related to package dependencies and management area: tools Development related to our toolchain (Docker, pipenv, flake8) category: core Related to core functionality status: needs review Author is waiting for someone to review and approve type: feature Relating to the functionality of the application. labels Sep 16, 2021
Bluenix2
Bluenix2 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good according to all documentation I could find.

jchristgit
jchristgit approved these changes Sep 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you.

auto-merge was automatically disabled September 24, 2021 18:37

Head branch was pushed to by a user without write access

@ChrisLovering ChrisLovering merged commit ff099d9 into python-discord:main Sep 24, 2021
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@jchristgit jchristgit jchristgit approved these changes

+1 more reviewer

@Bluenix2 Bluenix2 Bluenix2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: dependencies Related to package dependencies and management area: tools Development related to our toolchain (Docker, pipenv, flake8) category: core Related to core functionality type: feature Relating to the functionality of the application.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Full support for Gitpod

6 participants

@Kronifer @onerandomusername @ChrisLovering @jchristgit @Bluenix2 @Xithrius