Skip to content

Change pascal's triangle image#889

Merged
wookie184 merged 2 commits into
mainfrom
fix-pascal-triangle-image
Oct 14, 2021
Merged

Change pascal's triangle image#889
wookie184 merged 2 commits into
mainfrom
fix-pascal-triangle-image

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

@TizzySaurus TizzySaurus commented Oct 2, 2021

Relevant Issues

Closes #888

Description

I changed the image associated to the pascal's triangle question via editing the trivia_quiz.json file.

Image shows before and after: (tried to find a smaller image but wasn't successful)
image

Did you:

@TizzySaurus TizzySaurus added type: bug Something isn't working area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve category: fun Related to fun and games labels Oct 2, 2021
Copy link
Copy Markdown
Contributor

@Objectivitix Objectivitix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Expanding from this issue, we should probably establish a standard stating which reliable sites should we use images from (or even store them locally as binary files). Perhaps we can put it in the contributing guidelines?

@wookie184 wookie184 enabled auto-merge October 9, 2021 14:19
@wookie184 wookie184 merged commit 210a97a into main Oct 14, 2021
@wookie184 wookie184 deleted the fix-pascal-triangle-image branch October 14, 2021 21:35
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities category: fun Related to fun and games type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pascal's Triangle Image in .quiz command doesn't render

5 participants