Add Better Support For Whitelisting DM Commands#953
Merged
Conversation
Adds a toggle to the whitelist override, to allow explicit enabling of a command in DMs, and sets the default to False. Removes redundant `guild_only` decorators. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
area: backend
Contributor
Author
|
The French take this one |
Xithrius
added
the
status: needs review
Bluenix2
reviewed
Dec 15, 2021
|
|
||
| await self._play_game(ctx, user, board_size, str(emoji1), str(emoji2)) | ||
|
|
||
| @guild_only() |
Contributor
There was a problem hiding this comment.
Why can this be removed? The code that now handles DM-only checks is in the whitelist decorators, but that isn't applied here.
Contributor
Author
There was a problem hiding this comment.
The whitelist decorator is applied globally here:
Line 10 in 377dcf9
Bluenix2
approved these changes
Dec 16, 2021
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
I am just gonna start handing out high fives to everyone. This is great thank you!
ChrisLovering
approved these changes
Jan 1, 2022
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #952
Description
Disabled commands in DMs by default. Note that this only disables the invocation of a command in DMs, not handling of messages. This means commands which use DMs for other purposes, such as
battleshipwill still work. (Tested with a game of battleship against @Akarys42. Issue will be updated with the victor)Adds a toggle to the whitelist override utility, to allow explicit enabling of a command in DMs.
Did you: