fix: hanukkah command respects month boundaries#959
Merged
Conversation
rewrote hanukkah to use datetime.strptime left a helper method and some variables in order to allow extending to use a cache in the future, rather than requesting the api every invoke that is out of scope of this commit and pull, since the command is currently broken. I've only kept the same functionality, without trying to rewrite the entire command.
onerandomusername
force-pushed
the
fix-hanukkah-command
branch
from
9b1b92f to
65398ed
Compare
Contributor
Author
New results:
Current result, of which this pr is to fix:
|
ChrisLovering
approved these changes
Dec 1, 2021
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Works well, manually tested by editing the date it was using for today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
https://canary.discord.com/channels/267624335836053506/635950537262759947/915621871960092712
Description
rewrote hanukkah to use datetime.strptime
left a helper method and some variables in order to allow extending
to use a cache in the future, rather than requesting the api every invoke
that is out of scope of this commit and pull, since the command is
currently broken.
I've only kept the same functionality, without trying to rewrite the
entire command.
Did you: