yank lovefest command#971
Merged
Xithrius merged 5 commits intoDec 15, 2021
Merged
Conversation
add exceptions and handler for commands that move locations
onerandomusername
force-pushed
the
yank-lovefest-sub
branch
from
74dd25a to
2d07608
Compare
ChrisLovering
requested changes
Dec 3, 2021
ChrisLovering
approved these changes
Dec 4, 2021
Xithrius
added
area: backend
Xithrius
approved these changes
Dec 15, 2021
Xithrius
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that !subscribe exists on Python, the lovefest command is irrelevant
Relevant Issues
Partially closes #970 -- lovefest migration
Description
Added a custom error that would be handled by the error handler, in order to deal with this migrations in the future. This has the benefit of only needing to raise an exception with the new command, and the error will be logged and an embed shown to the user.
Because there are not stats on lance, I intentionally left not deleting the embed, as this can be a makeshift stat by searching for instances of lance's messages mentioning the new command to use.
Did you: