AoC month changes

[ChrisLovering]

Description

This allows AoC commands to be ran in January, along with limiting AoC join to only be ran in Nov, Dec and Jan.

This also removes the aoc subscribe command, since Python has a replacement for it now.

Did you:

• Join the Python Discord Community?
• Read all the comments in this template?
• Ensure there is an issue open, or link relevant discord discussions?
• Read and agree to the contributing guidelines?

[onerandomusername]

e7e0238

Dupe of #972

Actually, this isn't even a dupe as it doesn't use the already existing errors.

[onerandomusername]

.aoc stats needs a restrictive decorator as well.

Might want to consider it for .aoc refresh as well, even though its staff only, it would cause a sentry issue.

[ChrisLovering]

.aoc stats needs a restrictive decorator as well.

Might want to consider it for .aoc refresh as well, even though its staff only, it would cause a sentry issue.

Feel free to open an issue. Don't want to delay this PR though.

[onerandomusername]

Feel free to open an issue. Don't want to delay this PR though.

Everything else works, this will just cause a sentry error in February as the code isn't made for that. (Tried it with month override to February.)

If I don't open an issue sentry will

[onerandomusername]

looks good enough, few bugs, but as stated above, worth the risk.

[ChrisLovering]

Feel free to open an issue. Don't want to delay this PR though.

Everything else works, this will just cause a sentry error in February as the code isn't made for that. (Tried it with month override to February.)

If I don't open an issue sentry will

"the code isn't made for that". Yes it is, you just need to set the AOC_YEAR env var, otherwise it will try to get next year's leaderboard.

Please don't make assumptions about the code and then say there are a "few bugs".

[onerandomusername]

Yes it is, you just need to set the AOC_YEAR env var, otherwise it will try to get next year's leaderboard.

No where is it documented that this variable has to be set in production. The contributing guide says debug, which I presumed would not need to be used in prod.

link to guide

I now understand that it is currently being used in prod, but this was not made clear in the issue body, nor comments, until after my review.

[ChrisLovering]

Yes it is, you just need to set the AOC_YEAR env var, otherwise it will try to get next year's leaderboard.

No where is it documented that this variable has to be set in production. The contributing guide says debug, which I presumed would not need to be used in prod.

link to guide

I now understand that it is currently being used in prod, but this was not made clear in the issue body, nor comments, until after my review.

I can understand where you are coming from, really. The contribution guidelines can be made clearer in that respect, but there's only so much you can do with limited room in that table.

My point however was you are calling out this PR saying it has a few bugs. However, that area of the code hasn't even been changed in this PR, neither are they actual bugs.

While I don't mind it so much someone else, who is maybe new to contributing to our projects, would be put off by comments like this, so I wanted to raise it here so that it doesn't happen to someone else.

[onerandomusername]

While I don't mind it so much someone else, who is maybe new to contributing to our projects, would be put off by comments like this, so I wanted to raise it here so that it doesn't happen to someone else.

yeah ofc

[janine9vn]

Nicely written code and works like a charm.

There is some consistency changes with the decorator month locks for this cog I'd like to see happen, but it doesn't have to be this PR and I'd rather get this PR merged asap. I'll make a separate PR to kaizen this cog a bit.

[Den4200]

Splendid job! Works nicely.