Patch Sir Robin to use a task to load in extensions#22
Merged
Conversation
brad90four
approved these changes
Mar 28, 2022
Contributor
brad90four
left a comment
brad90four
left a comment
There was a problem hiding this comment.
Nice, we will certainly need this functionality as the bot grows, and this will be a more robust solution.
lemonsaurus
approved these changes
Mar 31, 2022
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Oh hi my name is 🍋 and I approve of these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a tiny PR to make extension loading compatible with Cogs that call
wait_until..by themselves.