Feat/pep command#23
Merged
Merged
Conversation
lemonsaurus
approved these changes
Mar 31, 2022
Contributor
There was a problem hiding this comment.
This all looks very sane, which makes sense since the exact same code has already passed code review on our other bot.
I don't see the connector thing creating any kind of critical problem for this, either.
Since you've already tested it and provided proof of successful tests, and since we're under some time pressure, I'm happy to approve.
ChrisLovering
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the pep command from python-discord/bot, original source
With this, I have added an aiohttp client session to the bot instance. this can be used in future cogs/exts too.
Additionally, I implemented it as bare-bones as possible for review speed. In the actual python-discord/bot we are creating a resolver and connector, this would require additional dependencies. what I'm talking about
screenshots
Here is examples of the embeds generated.
Links redirect to the correct sites
