Advent of Code Migration from Sir Lancebot#66
Merged
Conversation
There may be some unnecessary constants, but I ported over at least what's required for AoC.
This commit migrates the Advent of Code cog. It's *almost* a straight port of the features. Some things that were changed: Some of the usage for RedisSession and RedisCache were changed. Lancebot AoC was not updated for the newer async-rediscache. with aioredis being deprecated it made things complicated. Overall functionality is not changed though. I changed where the `about.json` lives. I didn't want to make a whole new folder structure for one file. I promise it works. Some of the import statements had to change. Instead of `from bot.bot import bot` we now have `from bot.bot import SirRobin`.
This was referenced Nov 28, 2022
minalike
reviewed
Nov 30, 2022
minalike
approved these changes
Nov 30, 2022
MarkKoz
approved these changes
Nov 30, 2022
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Can someone make time to figure out which utilities are common and create an issue for them to be migrated to bot-core? The copy-pasting is fine for now given the urgency.
Will the AoC extension on the other bot be disabled for the time being, or is there a PR soon to remove that code?
Contributor
|
I did not intend for my comments to block the merge (given that they were left with an approval). I don't know why GH is blocking. Feel free to resolve them whenever you want to merge this. I assume you're still waiting for env vars to be set in prod? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a migration of the Advent of Code cog, mostly as-is, from Sir Lancebot to Sir Robin. This is as close to a straight migration as I could manage. Any changes or improvements we want will be made in subsequent PRs once this is merged in.
How do I review this?
I've split this up into 4 commits, grouped by collections of files/changes:
utils/filesconstants.pyfileThe commits have information about what is not quite the straight port. Spoiler alert: it's some import statements and parts of the Redis Cache. Everything else is a straight copy/paste or drag/drop.
If you'd like to test this with minimal effort, I can provide most of my
.envfile that includes the leaderboard session cookie information. I can also provide you access to my test server where it should have the roles and constants configured for my.envfile.