Code Jam Permissions Update and a little bit extra#88
Merged
Conversation
Discussed internally, ping Kat if you have questions of why those specific roles and permissions
janine9vn
force-pushed
the
cj-perms-update
branch
from
b31c9b8 to
a5d29d3
Compare
When teams are announced, it will also ping the team in their team channel with the team info. Fixes a d.py change in UI view on_error argument positions.
janine9vn
force-pushed
the
cj-perms-update
branch
from
a5d29d3 to
00479bf
Compare
HassanAbouelela
approved these changes
Aug 28, 2023
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
Cant test, but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects some permissions issues from last year:
Why do we have to override permissions on the individual channels when it's being added to the category is a reasonable question you might ask when looking at this PR. The answer lies in the hell that is the Discord channel permission system. When creating a channel from a category, if you override the permissions during creation, it will not inherit the permissions from the category. We override the permissions on creation to add the individual team roles. So therefore we need to duplicate some efforts to make sure we cover our bases.
Also this change will ping teams in their team channels when we announce. This is a QoL change requested from last year that I went ahead and implemented since I had to edit the
_views.pyfile anyway.Also d.py changed the ordering of their arguments for the UI
on_errorfunction, so I had to correct that as well.