Patch cj end to upload a file instead of paste service#89
Closed
D0rs4n wants to merge 3 commits into
Closed
Conversation
Contributor
D0rs4n
commented
Aug 28, 2023
D0rs4n
commented
- Due to changes in the interface of the Paste Service, for the duration of the code jam, the bot will send a text file.
- Due to changes in the interface of the Paste Service, for the duration of the code jam, the bot will send a text file.
janine9vn
approved these changes
Aug 28, 2023
Contributor
janine9vn
left a comment
janine9vn
left a comment
There was a problem hiding this comment.
tested and works nicely. Just a super small comment about a double period. Not required to merge.
Comment on lines
+124
to
+125
| name="Roles, categories and channels will be deleted..", | ||
| value="For an exhaustive list see the attached file.." |
Contributor
There was a problem hiding this comment.
Duplicate period for these two, not major though.
ChrisLovering
approved these changes
Aug 28, 2023
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
A better approach would be to bump bot core to 10.X and use the util from there, as it would be a drop-in replacement as far as I can tell.
Approving this just in case there is a time concern for this PR.
Member
Since I wanted to update bot-core anyway, I've done this change in #91 |
Member
|
superseded by #91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.