-
-
Notifications
You must be signed in to change notification settings - Fork 137
fix: update bot's required version and contrib deadlinks #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update bot's required version and contrib deadlinks #1566
Conversation
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| Below are the dependencies you **must** have installed to get started with the bot. | ||
|
|
||
| 1. Make sure you have [Python 3.12](https://www.python.org/downloads/) installed. It helps if it is your system's default Python version. | ||
| 1. Make sure you have [Python 3.13](https://www.python.org/downloads/) installed. It helps if it is your system's default Python version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC uv installs the Python version you need for you so this step probably isn't necessary any more I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be useful to keep somewhat documented, as uv installed from a distro-packaged uv may result in a uv with automatic downloads to be disabled without the user knowing.
Reference: astral-sh/uv#15625
https://src.fedoraproject.org/rpms/uv/blob/rawhide/f/uv.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also matches the existing contributing guides for sir-lancebot and site which don't mention that uv can install python. That feels out of scope for this pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it but probably remove the note about it being system Python. UV is good at discovering it even if it's non-system (for example on macOS I use Homebrew versions of Python, but UV figures that out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Thanks! |
Planned to merge these with a larger update to the contributing documentation, but wanted to get these out of the way so they don't get held up by my time constraints.