Fix version commit count#141
Merged
Merged
Conversation
The last part of the version is the commit count, which relies on the repo's commit history.
The env var is no longer used anywhere.
MarkKoz
added
area: CI
HassanAbouelela
approved these changes
Jun 1, 2022
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
Everything looks good here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit count was off by 1 since the last newline was being stripped and thus not counted. In CI, the checkout action was not retrieving history, so the commit count was not able to get the right number of commits. I set it to fetch 100 commits, which should be more than reasonably safe; it would take over 100 commits on the release day to cause the version to be incorrect, and even then it's only really a problem if a second release happens on the same day.