Skip to content

Enable 3.13's colorized output (snekbox half)#225

Merged
ChrisLovering merged 1 commit into
python-discord:mainfrom
thurisatic:colorsnek
Nov 14, 2024
Merged

Enable 3.13's colorized output (snekbox half)#225
ChrisLovering merged 1 commit into
python-discord:mainfrom
thurisatic:colorsnek

Conversation

@thurisatic
Copy link
Copy Markdown
Contributor

This PR is the snekbox side of changes made to allow bot's !eval to support colored output. The first of the two commits for bot's side allows ANSI codes to be rendered when given via print or such, but Python 3.13 does not produce these colors in tracebacks without an environment variable. Per documentation, there are two such envars - PYTHON_COLORS and FORCE_COLOR. Testing has shown FORCE_COLOR to have no effect in eval output, while PYTHON_COLORS (even by itself) produces colored tracebacks.

The insertion of ANSI codes produces significant problems when code is long enough to require uploading to pinnwand, however, so this PR probably should not be merged unless the Prevent 3.13's ANSI escapes from mangling pinnwand uploads commit from bot's PR is also merged, which fixes the problems.

python-discord/bot#3198 is bot's half

@ChrisLovering ChrisLovering enabled auto-merge (squash) November 14, 2024 21:40
Copy link
Copy Markdown

@Jayy001 Jayy001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@ChrisLovering ChrisLovering merged commit 1787c47 into python-discord:main Nov 14, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 89.158%. remained the same
when pulling 1d4c848 on thurisatic:colorsnek
into 2fc04c6 on python-discord:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants