Add pep8-naming and more pre-commit hooks

[MarkKoz]

Relevant Issues

Resolves #63
python-discord/organisation#138

Description

New hooks were added for pre-commit and they will run in CI too. The pipenv run lint script will now run all the new hooks, including flake8.

Hooks added

A couple of these hooks automatically apply fixes. However, they still report failure and leave any changes they make uncommitted. Therefore, the user has to commit the automatic fixes.

• check-merge-conflict - Check for files that contain merge conflict strings.
• check-toml - Attempts to load all toml files to verify syntax.
• check-yaml - Attempts to load all yaml files to verify syntax.
• end-of-file-fixer - Makes sure files end in a newline and only a newline.
• mixed-line-ending - Replaces mixed line endings with LF.
• trailing-whitespace - Trims trailing whitespace.
• python-check-blanket-noqa - Enforce that noqa annotations always occur with specific codes

Reasoning

• Dev dependencies were updated and re-pinned because why not? They were getting old enough. I'm just following along with the other repos.
• No cache used for pre-commit because it runs in a Docker container. I suppose it could be copied to the container from the cache on the host, but that doesn't seem worthwhile.

[MarkKoz]

pre-commit fails to run cause git is not installed in the container. May need to rethink this...

[MarkKoz]

Build failing because pre-commit cannot find shellcheck

Test shell scripts with shellcheck.......................................Failed

• hook id: shellcheck
• exit code: 127

/root/.cache/pre-commit/repo_gx8xowx/pre_commit_hooks/shellcheck: 13: /root/.cache/pre-commit/repo_gx8xowx/pre_commit_hooks/shellcheck: shellcheck: not found

[MarkKoz]

Now I don't know why it fails. Maybe cause it's an older version (0.5.0). Shellcheck 0.7.1 doesn't complain locally.

Test shell scripts with shellcheck.......................................Failed
- hook id: shellcheck
- exit code: 1

In scripts/check_dockerfiles.sh line 22:
    if [[ -v build_cache["${branch}"] ]]; then
    ^-- SC1009: The mentioned syntax error was in this if expression.
       ^-- SC1073: Couldn't parse this test expression. Fix to allow more checks.
             ^-- SC1019: Expected this to be an argument to the unary condition.
                                     ^-- SC1020: You need a space before the ]].
                                     ^-- SC1072: Missing space before ]. Fix any mentioned problems and try again.


In scripts/dev.sh line 17:
    && printf " done!\n" || exit "$?"
                     ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In scripts/dev.sh line 28:
            && printf " done!\n" || exit "$?"
                             ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".

[MarkKoz]

Okay, I give up on ShellCheck. I can't install from the tarball cause the container doesn't have xz to decompress it. I could install xz but this just isn't worth it any more. I should honestly rewrite the shell scripts in Python anyway.

[coveralls]

Coverage remained the same at 93.421% when pulling e8e27a9 on feat/deps/63/pep8-naming into 9ff15de on master.

[MarkKoz]

@Xithrius Are you planning on finishing this? If I remember correctly, @SebastiaanZ was since he did #79 but I think he's been too busy. If you are, then the CI stuff here still needs to be migrated to GH Actions. Otherwise, I should find time to finish this myself since it is my PR after all.

By the way, why are you putting "rebase" in your commit summaries when they look like they are merge commits, not rebases? If you were to actually rebase master, that would have required a force push.

[Xithrius]

@Xithrius Are you planning on finishing this?

I don't know how to properly test this PR, so it would probably be best for you to finish this up.

By the way, why are you putting "rebase" in your commit summaries when they look like they are merge commits, not rebases?

I've accidentally used the wrong terminology, thank you for pointing that out.

[jb3]

This all looks good. Everything works perfect locally.