Skip to content

Add sentry integration#65

Merged
MarkKoz merged 3 commits into
masterfrom
sentry-integration
Mar 8, 2020
Merged

Add sentry integration#65
MarkKoz merged 3 commits into
masterfrom
sentry-integration

Conversation

@jb3
Copy link
Copy Markdown
Member

@jb3 jb3 commented Mar 8, 2020

Integrates Sentry with Snekbox.

Adds the FalconIntegration as well to handle Internal Server errors.

Note: This could not be tested locally because Docker & Pipenv on MacOS are hyper-broken for me.

@jb3 jb3 requested a review from a team as a code owner March 8, 2020 21:53
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't lock pipenv:

Your Pipfile.lock (69cca1) is out of date. Expected: (829e3b).

Comment thread Pipfile Outdated
Co-Authored-By: Mark <kozlovmark@gmail.com>
@MarkKoz MarkKoz added area: backend Related to internal functionality and utilities priority: 2 - normal type: feature New feature or request labels Mar 8, 2020
@jb3
Copy link
Copy Markdown
Member Author

jb3 commented Mar 8, 2020

pipenv is broken.

the world is crumbling.

@MarkKoz
Copy link
Copy Markdown
Contributor

MarkKoz commented Mar 8, 2020

Will someone else need to lock and push it?

@jb3
Copy link
Copy Markdown
Member Author

jb3 commented Mar 8, 2020

I'm locking it now, I fixed pipenv by deleting all my .DS_Store files since pipenv cannot handle it.

@MarkKoz MarkKoz merged commit 540263c into master Mar 8, 2020
@MarkKoz MarkKoz deleted the sentry-integration branch March 8, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities priority: 2 - normal type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants