This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Add keyword arg to let Bottle listen on all interfaces#155
Merged
ChrisKnott merged 1 commit intopython-eel:masterfrom Jun 16, 2019
Merged
Add keyword arg to let Bottle listen on all interfaces#155ChrisKnott merged 1 commit intopython-eel:masterfrom
ChrisKnott merged 1 commit intopython-eel:masterfrom
Conversation
Added option to allow bottle server to listen on all interfaces. Bottle allows listening on all interfaces when the host is set to '0.0.0.0' as per documentation: https://bottlepy.org/docs/dev/deployment.html Without this change setting the host to '0.0.0.0' via eel options fails because this is not a valid address for the web browser to navigate to in order to access the server. The added keyword arg still allows a single IP address to be specified for the browser that eel launches to use, but passes '0.0.0.0' to the bottle server so that the GUI can be accessed on all IP addresses. For example, both 'localhost' and one or more LAN IPs. Default is set so that behavior does not change unless this new keyword arg is specifically added and set to True.
Collaborator
|
Added 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #139
Added option to allow bottle server to listen on all interfaces. Bottle allows listening on all interfaces when the host is set to '0.0.0.0' as per documentation: https://bottlepy.org/docs/dev/deployment.html
Without this change setting the host to '0.0.0.0' via eel options fails because this is not a valid address for the web browser to navigate to in order to access the server. The added keyword arg still allows a single IP address to be specified for the browser that eel launches to use, but passes '0.0.0.0' to the bottle server so that the GUI can be accessed on all IP addresses. For example, both 'localhost' and one or more LAN IPs. Default is set so that behavior does not change unless this new keyword arg is specifically added and set to True.