This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Fix wrong arguments for URL to GitHub#209
Merged
samuelhwilliams merged 2 commits intopython-eel:masterfrom Nov 18, 2019
andriyor:master
Merged
Fix wrong arguments for URL to GitHub#209samuelhwilliams merged 2 commits intopython-eel:masterfrom andriyor:master
samuelhwilliams merged 2 commits intopython-eel:masterfrom
andriyor:master
Conversation
use full readme.md for long_description use absolute pointing at github raw image
ChrisKnott
reviewed
Nov 17, 2019
Collaborator
There was a problem hiding this comment.
Thanks for doing this - looks like it does indeed work now (https://test.pypi.org/project/Eel/0.11.0/), albeit I need you to make one addition as suggested below (you should be able to click to accept it).
Once that's in, I'll approve and we can merge it.
Really appreciate you taking the time to put up this pull request.
Co-Authored-By: Samuel Williams <samuelhwilliams@users.noreply.github.com>
samuelhwilliams
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warehouse now uses the
urlprovided to display links in the sidebar, as well as including them in API responses to help automation tool find the source code for Eel. For example, see Django's setup.cfg and PyPI listing.PyPI also already support rendering project descriptions from Markdown https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi/