This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Allow user-configurable timeout on JS execution#218
Merged
samuelhwilliams merged 2 commits intomasterfrom Dec 6, 2019
Merged
Conversation
Python currently tries for 10 seconds, checking every millisecond, to collect values returned by Javascript functions called via Eel. Some users might expect their functions to execute longer than this, and so it feels reasonable to allow users to configure this to be longer (or shorter) as suits their needs. Resolves #182
samuelhwilliams
force-pushed
the
configurable-timeout
branch
from
e45b129 to
7ba44f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python currently tries for 10 seconds, checking every millisecond, to
collect values returned by Javascript functions called via Eel. Some
users might expect their functions to execute longer than this, and so
it feels reasonable to allow users to configure this to be longer (or
shorter) as suits their needs.
Resolves #182