This repository was archived by the owner on Jun 22, 2025. It is now read-only.
fix(mac,chrome): search for chromium also#279
Merged
samuelhwilliams merged 1 commit intopython-eel:masterfrom Apr 20, 2020
Merged
fix(mac,chrome): search for chromium also#279samuelhwilliams merged 1 commit intopython-eel:masterfrom
samuelhwilliams merged 1 commit intopython-eel:masterfrom
Conversation
samuelhwilliams
approved these changes
Apr 20, 2020
Collaborator
|
Thanks @matejc!. Edit: This is now released as part of v0.12.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for searching for Chromium also (if Chrome is not found). This feature is useful because I am running Eel inside CI for multi-platform image recognition tests on Travis-CI and Chrome at first start on new environment is demanding user interaction before launching anything useful, on the other hand Chromium does not do that.