Skip to content

fix #378, loosen SQLAlchemy version requirement#382

Merged
wwwjfy merged 1 commit intopython-gino:masterfrom
wwwjfy:sqlalchemy-version
Nov 5, 2018
Merged

fix #378, loosen SQLAlchemy version requirement#382
wwwjfy merged 1 commit intopython-gino:masterfrom
wwwjfy:sqlalchemy-version

Conversation

@wwwjfy
Copy link
Copy Markdown
Member

@wwwjfy wwwjfy commented Nov 4, 2018

For projects having both Gino and SQLAlchemy as dependencies, this helps to solve the conflicts.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1320

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.308%

Totals Coverage Status
Change from base Build 1319: 0.0%
Covered Lines: 4008
Relevant Lines: 4077

💛 - Coveralls

Copy link
Copy Markdown
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite some discussions about pinning versions. I think it is a reasonable change here not to pin SQLAlchemy and asyncpg.

@wwwjfy
Copy link
Copy Markdown
Member Author

wwwjfy commented Nov 5, 2018

won't apply it to asyncpg, which I assume in most cases it won't be used directly by a project.

@wwwjfy wwwjfy merged commit 4553927 into python-gino:master Nov 5, 2018
@wwwjfy wwwjfy deleted the sqlalchemy-version branch November 5, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants