fix #378, loosen SQLAlchemy version requirement#382
Merged
wwwjfy merged 1 commit intopython-gino:masterfrom Nov 5, 2018
Merged
fix #378, loosen SQLAlchemy version requirement#382wwwjfy merged 1 commit intopython-gino:masterfrom
wwwjfy merged 1 commit intopython-gino:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1320
💛 - Coveralls |
fantix
approved these changes
Nov 5, 2018
Member
fantix
left a comment
There was a problem hiding this comment.
There are quite some discussions about pinning versions. I think it is a reasonable change here not to pin SQLAlchemy and asyncpg.
Member
Author
|
won't apply it to asyncpg, which I assume in most cases it won't be used directly by a project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For projects having both Gino and SQLAlchemy as dependencies, this helps to solve the conflicts.