Conversation
Pull Request Test Coverage Report for Build 1751
💛 - Coveralls |
|
Thank you for taking this on Tony - this is awesome. Testing this out with FastAPI (object inherits the Starlette model, so this should work for it). Runs very well locally - will troubleshoot a bit (doesn't yet fix my issue with Cloud Run, but that's an issue for another day & I'm pretty sure that has more to do with asyncpg than Gino). It does require a bit of reorganization of my code (I define db in my models & import to main.py, which this isn't happy with unless route imports come below db definition) but this is not the end of the world. |
|
Glad to hear that. Let us know if you have other ideas how to organise it and make it more user friendly. :) |
|
Please feel free to merge - I'm sorry I don't have time to review recently. Thanks a lot for the good work! |
No description provided.