Skip to content

Provide ASGI compatibility through server event#520

Merged
wwwjfy merged 1 commit intopython-gino:masterfrom
tng10:patch-1
Aug 8, 2019
Merged

Provide ASGI compatibility through server event#520
wwwjfy merged 1 commit intopython-gino:masterfrom
tng10:patch-1

Conversation

@tng10
Copy link
Copy Markdown
Contributor

@tng10 tng10 commented Aug 8, 2019

Change server event (listener)

from
@swagger_blueprint.listener("before_server_start")
to
@swagger_blueprint.listener("after_server_start")

and

from
@swagger_blueprint.listener("after_server_stop")
to
@swagger_blueprint.listener("before_server_stop")

More details at
https://sanic.readthedocs.io/en/latest/sanic/deploying.html#running-via-asgi

Change server event (listener) 

from 
```@swagger_blueprint.listener("before_server_start")```
 to 
```@swagger_blueprint.listener("after_server_start")```

**and**

from 
```@swagger_blueprint.listener("after_server_stop")```
 to 
```@swagger_blueprint.listener("before_server_stop")```

More details at
https://sanic.readthedocs.io/en/latest/sanic/deploying.html#running-via-asgi
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1802

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.573%

Totals Coverage Status
Change from base Build 1788: 0.0%
Covered Lines: 4215
Relevant Lines: 4276

💛 - Coveralls

@wwwjfy
Copy link
Copy Markdown
Member

wwwjfy commented Aug 8, 2019

Thanks!

@wwwjfy wwwjfy merged commit 7ae6e1e into python-gino:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants