Skip to content

Conversation

@jim-obrien-orig
Copy link
Contributor

Change gino.ext.starlette to use factory method like the other extensions, as well as __init__. Now init with either Gino(app, ...) or db = Gino(); db.init_app(app)

@coveralls
Copy link

coveralls commented Sep 4, 2019

Pull Request Test Coverage Report for Build 1836

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 98.577%

Totals Coverage Status
Change from base Build 1825: 0.004%
Covered Lines: 4227
Relevant Lines: 4288

💛 - Coveralls

Copy link
Contributor Author

@jim-obrien-orig jim-obrien-orig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed I changed pipenv.lock by mistake, so I'm resetting that to what it was on master. Same for .gitignore.

@wwwjfy
Copy link
Member

wwwjfy commented Sep 7, 2019

Could you revert the format change made in the last commit? It makes the diff less readable and single line longer than 79 characters.

@jim-obrien-orig
Copy link
Contributor Author

Sorry about that. Vim formatted on save. Don't usually use it for python.

@wwwjfy wwwjfy merged commit f5e2db3 into python-gino:master Sep 8, 2019
@wwwjfy
Copy link
Member

wwwjfy commented Sep 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants