-
Notifications
You must be signed in to change notification settings - Fork 150
factory method gino.ext.starlette #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1836
💛 - Coveralls |
jim-obrien-orig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed I changed pipenv.lock by mistake, so I'm resetting that to what it was on master. Same for .gitignore.
|
Could you revert the format change made in the last commit? It makes the diff less readable and single line longer than 79 characters. |
|
Sorry about that. Vim formatted on save. Don't usually use it for python. |
|
Thanks! |
Change
gino.ext.starletteto use factory method like the other extensions, as well as__init__. Now init with eitherGino(app, ...)ordb = Gino(); db.init_app(app)