Skip to content

Fix handling of within-descendant-imports when squashing modules#196

Merged
seddonym merged 3 commits intopython-grimp:masterfrom
Peter554:fix-issue-195
Mar 12, 2025
Merged

Fix handling of within-descendant-imports when squashing modules#196
seddonym merged 3 commits intopython-grimp:masterfrom
Peter554:fix-issue-195

Conversation

@Peter554
Copy link
Collaborator

@Peter554 Peter554 commented Mar 11, 2025

Fixes #195 (I'm pretty sure - hard to be 100% certain without seeing the respository in question).

@Peter554 Peter554 changed the title Fixed handling of within-descendant-imports when squashing modules Fix handling of within-descendant-imports when squashing modules Mar 11, 2025
@Peter554
Copy link
Collaborator Author

FYI @seddonym @mariusgoertz

Copy link
Collaborator

@seddonym seddonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly!

@Peter554 Peter554 marked this pull request as ready for review March 11, 2025 15:56
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #196 will not alter performance

Comparing Peter554:fix-issue-195 (650eb7e) with master (f6c537e)

Summary

✅ 19 untouched benchmarks

@mariusgoertz
Copy link

Fixes #195 (I'm pretty sure - hard to be 100% certain without seeing the respository in question).

i checked out the fix and tested it and can confirm its working again now! thanks!

@seddonym seddonym merged commit d780fe4 into python-grimp:master Mar 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error handling in ModuleTokenIterator

3 participants