Address issue with setting up the partial cache in benchmark#200
Address issue with setting up the partial cache in benchmark#200
Conversation
014287e to
a4df452
Compare
CodSpeed Instrumentation Performance ReportMerging #200 will degrade performances by 65.02%Comparing Summary
Benchmarks breakdown
|
89ffa6f to
cdc9d2a
Compare
Peter554
left a comment
There was a problem hiding this comment.
A bit awkward, but seems a good idea.
I'm a bit confused that the benchmark seems to take the same time as fully from the cache - I would have expected it to be a bit slower. I suppose 2 and 15 are not very big numbers, maybe it makes sense to add a case where we are missing 100, or 1000 cache entries.
cdc9d2a to
b5a86ae
Compare
CodSpeed Walltime Performance ReportMerging #200 will not alter performanceComparing Summary
|
Prior to this, the cache would get populated after the first iteration and after that it would behave as if it was a fully-populated cache.
b5a86ae to
3bfddd4
Compare
I've added one for 350 misses (about half of Django). It does slow the benchmarking job down quite a bit unfortunately, maybe we can remove it later. I've also adjusted it so it copies a real module from Django instead of a one-liner, so the parser will have more work to do. |
Prior to this, we would set up the state for the first iteration, but future iterations would be able to use the fully-populated cache.