Skip to content

Parallel import scanning demo#202

Closed
seddonym wants to merge 7 commits intomasterfrom
parallel-import-scanning-demo
Closed

Parallel import scanning demo#202
seddonym wants to merge 7 commits intomasterfrom
parallel-import-scanning-demo

Conversation

@seddonym
Copy link
Collaborator

@seddonym seddonym commented Apr 4, 2025

Demo PR to see how the benchmarks behave on the parallel import scanning PR.

This is currently using an earlier version of the import scanning which involved a regression if there was a completely populated cache.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #202 will improve performances by ×42

Comparing parallel-import-scanning-demo (cf2b9c2) with master (23a1e85)

Summary

⚡ 4 improvements
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_django_from_cache_a_few_misses[15] 375.6 ms 150 ms ×2.5
test_build_django_from_cache_a_few_misses[2] 164.4 ms 149 ms +10.35%
test_build_django_from_cache_a_few_misses[350] 5,790.1 ms 298 ms ×19
test_build_django_uncached 6,147.9 ms 145.4 ms ×42

Peter554 added 7 commits April 8, 2025 10:55
This is needed to ensure that the error can be sent between processes.

This ensures that the test `test_syntax_error_includes_module` still passes
after using multiprocessing.
This is helpful, to avoid having to pass the large cache object
to the multiprocessing code.
@seddonym seddonym force-pushed the parallel-import-scanning-demo branch from 3ac273f to cf2b9c2 Compare April 8, 2025 09:56
@seddonym seddonym closed this Apr 11, 2025
@seddonym seddonym deleted the parallel-import-scanning-demo branch April 11, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants