Move codspeed tox installation to earlier step#205
Merged
Conversation
f33f9b6 to
54dd8f3
Compare
54dd8f3 to
52dc1f8
Compare
CodSpeed Instrumentation Performance ReportMerging #205 will improve performances by 43.73%Comparing 🎉 Hooray!
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | test_copy_graph |
80.6 ms | 56.1 ms | +43.73% |
| ⚡ | test_find_descendants |
41.5 ms | 36.2 ms | +14.7% |
| ⚡ | test_find_upstream_modules |
3.9 ms | 3.4 ms | +14.92% |
c43f174 to
52dc1f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up the benchmarking step job in CI.
Prior to this, we would run pytest via
tox -ecodspeed. This meant that codspeed would run the installation of packages under valgrind, which is much slower.This is a quick-and-dirty approach which changes the codspeed action to use
uvto install the packages. This seems to reduce the time from around 17 minutes to 10 minutes. For some reason it's still installing reinstalling grimp, but it's better than it was.