Skip to content

Move codspeed tox installation to earlier step#205

Merged
seddonym merged 2 commits intomasterfrom
move-codspeed-tox-installation-to-earlier-step
Apr 8, 2025
Merged

Move codspeed tox installation to earlier step#205
seddonym merged 2 commits intomasterfrom
move-codspeed-tox-installation-to-earlier-step

Conversation

@seddonym
Copy link
Collaborator

@seddonym seddonym commented Apr 7, 2025

Speeds up the benchmarking step job in CI.

Prior to this, we would run pytest via tox -ecodspeed. This meant that codspeed would run the installation of packages under valgrind, which is much slower.

This is a quick-and-dirty approach which changes the codspeed action to use uv to install the packages. This seems to reduce the time from around 17 minutes to 10 minutes. For some reason it's still installing reinstalling grimp, but it's better than it was.

@seddonym seddonym force-pushed the move-codspeed-tox-installation-to-earlier-step branch 5 times, most recently from f33f9b6 to 54dd8f3 Compare April 7, 2025 16:46
@seddonym seddonym force-pushed the move-codspeed-tox-installation-to-earlier-step branch from 54dd8f3 to 52dc1f8 Compare April 7, 2025 16:49
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 7, 2025

CodSpeed Instrumentation Performance Report

Merging #205 will improve performances by 43.73%

Comparing move-codspeed-tox-installation-to-earlier-step (52dc1f8) with master (a318714)

🎉 Hooray! pytest-codspeed just leveled up to 3.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 3 improvements
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_copy_graph 80.6 ms 56.1 ms +43.73%
test_find_descendants 41.5 ms 36.2 ms +14.7%
test_find_upstream_modules 3.9 ms 3.4 ms +14.92%

@seddonym seddonym force-pushed the move-codspeed-tox-installation-to-earlier-step branch from c43f174 to 52dc1f8 Compare April 8, 2025 07:05
@seddonym seddonym marked this pull request as ready for review April 8, 2025 07:24
@seddonym seddonym merged commit 7161f96 into master Apr 8, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant