Skip to content

Adapt / remove unit tests of private methods#223

Merged
seddonym merged 1 commit intomasterfrom
unit-tests-import-scanner-no-private-methods
Jun 11, 2025
Merged

Adapt / remove unit tests of private methods#223
seddonym merged 1 commit intomasterfrom
unit-tests-import-scanner-no-private-methods

Conversation

@seddonym
Copy link
Collaborator

We're going to move to a Rust-based ImportScanner class - we don't want to have to expose this private method. This moves the tests for non-ascii based scanning to a higher level test, and removes the rest. There are already lower level Rust tests.

We're going to move to a Rust-based ImportScanner class - we don't want
to have to expose this private method. This moves the tests for
non-ascii based scanning to a higher level test, and removes the rest.
There are already lower level Rust tests.
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Instrumentation Performance Report

Merging #223 will improve performances by 16.82%

Comparing unit-tests-import-scanner-no-private-methods (4b02c7c) with master (ce0d32f)

Summary

⚡ 3 improvements
✅ 19 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_deep_layers_large_graph_kept 19.8 ms 16.9 ms +16.82%
test_no_chain 1.2 ms 1.1 ms +12.35%
test_no_chains 1.2 ms 1.1 ms +12.35%

@seddonym seddonym marked this pull request as ready for review June 11, 2025 14:29
@seddonym seddonym merged commit 1d56065 into master Jun 11, 2025
18 checks passed
@seddonym seddonym deleted the unit-tests-import-scanner-no-private-methods branch June 11, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant