Skip to content

Conversation

@seddonym
Copy link
Collaborator

@seddonym seddonym commented Oct 28, 2025

Adds nominate_cycle_breakers method.

image

@seddonym seddonym changed the title Add nominate_cycle_breakers method Implement nominate_cycle_breakers method Oct 28, 2025
@seddonym seddonym mentioned this pull request Oct 28, 2025
5 tasks
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #258 will degrade performances by 12.53%

Comparing cycle-breakers-rust (caa957f) with main (b5faf4e)

Summary

❌ 1 (👁 1) regression
✅ 22 untouched
🆕 3 new
⏩ 23 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
👁 WallTime test_get_import_details 134.8 µs 154.1 µs -12.53%
🆕 WallTime test_nominate_cycle_breakers_django N/A 7.8 ms N/A
🆕 WallTime test_nominate_cycle_breakers_large_graph_root N/A 411.6 ms N/A
🆕 WallTime test_nominate_cycle_breakers_large_graph_subpackage N/A 181.7 ms N/A

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@seddonym seddonym force-pushed the cycle-breakers-rust branch from fc94888 to 11e353c Compare October 29, 2025 11:08
@seddonym seddonym force-pushed the cycle-breakers-rust branch from 11e353c to 0e20e66 Compare October 29, 2025 12:08
@seddonym seddonym marked this pull request as ready for review October 29, 2025 12:27
@seddonym seddonym force-pushed the cycle-breakers-rust branch from 0e20e66 to caa957f Compare October 29, 2025 12:27
@seddonym seddonym merged commit c8cda72 into main Oct 29, 2025
21 checks passed
@seddonym seddonym deleted the cycle-breakers-rust branch October 29, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants