Skip to content

Pick up new benchmarks automatically and improve github actions#146

Merged
zingale merged 4 commits intopython-hydro:mainfrom
yut23:tooling_improvements
Mar 23, 2023
Merged

Pick up new benchmarks automatically and improve github actions#146
zingale merged 4 commits intopython-hydro:mainfrom
yut23:tooling_improvements

Conversation

@yut23
Copy link
Copy Markdown
Collaborator

@yut23 yut23 commented Mar 23, 2023

Add coverage config file and install pyro with pip instead of running setup.py directly

@zingale
Copy link
Copy Markdown
Collaborator

zingale commented Mar 23, 2023

the coverage report is strange -- it seems to find the files both in .local and in the directory it cloned, so they all appear twice

@yut23
Copy link
Copy Markdown
Collaborator Author

yut23 commented Mar 23, 2023

I think we had a similar issue with pynucastro

@yut23
Copy link
Copy Markdown
Collaborator Author

yut23 commented Mar 23, 2023

Yep, that fixes it

@zingale
Copy link
Copy Markdown
Collaborator

zingale commented Mar 23, 2023

indeed, that looks a lot better now. Maybe we should switch all the actions to install it that way

@yut23 yut23 changed the title Pick up new benchmarks automatically and add coverage config Pick up new benchmarks automatically and improve github actions Mar 23, 2023
@zingale zingale merged commit 2b20cd5 into python-hydro:main Mar 23, 2023
@yut23 yut23 deleted the tooling_improvements branch March 23, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants