New solver for slotted-type advection problems#50
Merged
harpolea merged 11 commits intopython-hydro:masterfrom Sep 7, 2018
Merged
New solver for slotted-type advection problems#50harpolea merged 11 commits intopython-hydro:masterfrom
harpolea merged 11 commits intopython-hydro:masterfrom
Conversation
…s constant but nonuniform
Contributor
Author
|
I've updated my fork to resolve the conflict and they shouldn't be have any issue, I don't know why it still complains about the conflicts. |
Collaborator
|
@taataam, could you fix the merge conflicts and make sure the tests pass before we close this pull request? (I tried to do this on github but broke the tests, so it might be easier if you do it on your fork) Otherwise the code looks great! |
Collaborator
|
Also, it would be great if you could add the advection_uniform problem to solver_test.ipynb |
Contributor
Author
|
@harpolea I've made the requested changes and the conflicts are resolved. |
Collaborator
|
@taataam Great thanks! I'll merge this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #32 by adding a new advection solver. It considers the velocity field as nonuniform (constant) which allows to simulate problems such as Zalesk slotted disk. A new slotted problem is added other than the tophat and smooth ones.