Bug fix - error when hovering pop up window#85
Merged
zingale merged 1 commit intopython-hydro:masterfrom Feb 9, 2020
jmuzsik:master
Merged
Bug fix - error when hovering pop up window#85zingale merged 1 commit intopython-hydro:masterfrom jmuzsik:master
zingale merged 1 commit intopython-hydro:masterfrom
jmuzsik:master
Conversation
Collaborator
|
thanks for reporting this and for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This is in reference to #84.
For one,
cb.formatter = matplotlib.ticker.FormatStrFormatter("")prevents a bug in matplotlib where it expects a formatter attribute. The current format does not break the animation but you will see it if you click a chart while it is running and look in your terminal. It adds x and y axis data related to the chart as well as an []. The empty array has data by default that is quite meaningless soFormatStrFormatter("")gets rid of the data inside.My first instinct to fix this was this:
img = plt.imshow(np.transpose(var.v()),andplt.colorbar(img)because of this stack overflow page. I kept this change in code as it looks to be a best practice (though I am not sure the exact benefit).Otherwise, let me know if it works.
Jerry