Skip to content

Adapting curio-server.py to trio #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njsmith merged 6 commits into from
Jan 17, 2018
Merged

Adapting curio-server.py to trio #46

njsmith merged 6 commits into from
Jan 17, 2018

Conversation

@merrellb
Copy link
Contributor

@merrellb merrellb commented Apr 26, 2017

Combining my two favorite projects by @njsmith

@merrellb
Adapting curio-server.py to trio
8138b6d 
Combine my two favorite projects by @njsmith
@codecov
Copy link

codecov bot commented Apr 26, 2017 •
edited
Loading

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         904    908    +4     
  Branches      173    177    +4     
=====================================
+ Hits          904    908    +4
Impacted Files Coverage Δ
h11/_headers.py 100% <0%> (ø) ⬆️
h11/__init__.py
bench/benchmarks/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a880823...0837465. Read the comment docs.

@merrellb merrellb mentioned this pull request May 9, 2017
Closed
njsmith added 2 commits June 29, 2017 16:06
@njsmith
Remove redundant print
961a8cf
@njsmith
Close sockets when we're done with them
0837465 
The curio server helpers do this automatically; since here we're using
a lower-level API we need to do it by hand. (Of course in the future
trio will have its own helper API and we can get rid of all of this...)
@njsmith njsmith mentioned this pull request Jul 7, 2017
Closed
@codecov-io
Copy link

codecov-io commented Jan 17, 2018

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         904    908    +4     
  Branches      173    177    +4     
=====================================
+ Hits          904    908    +4
Impacted Files Coverage Δ
h11/_headers.py 100% <0%> (ø) ⬆️
h11/__init__.py
bench/benchmarks/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a880823...516c1a4. Read the comment docs.

@njsmith
Copy link
Member

njsmith commented Jan 17, 2018

Now that Trio finally has a solid set of highlevel networking APIs, I just updated this to use them and switched over the examples to using Trio consistently. Now let's see what Travis thinks...

@njsmith
Copy link
Member

njsmith commented Jan 17, 2018

...or maybe this is a doc-only change and we don't currently test docs, plus travis is down anyway. YOLO!

@njsmith njsmith merged commit f6dcd92 into python-hyper:master Jan 17, 2018
@jmehnle
Copy link

jmehnle commented Jun 27, 2018

I wish you hadn't removed the curio example. It's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@merrellb @codecov-io @njsmith @jmehnle