fix: reject conflicting content-length headers#1317
Open
Harshal96 wants to merge 2 commits into
Open
Conversation
Kriechi
reviewed
May 14, 2026
| if n == b"content-length": | ||
| try: | ||
| self._expected_content_length = int(v, 10) | ||
| content_lengths.append(int(v, 10)) |
Member
There was a problem hiding this comment.
Could this lead to a DoS if a malicous payload keeps sending new differing content-length headers and this list keeps growing?
Contributor
Author
There was a problem hiding this comment.
No, I don't think so, it'll be discarded once _initialize_content_length() exits, but I think I have a better idea where only comparing the lengths can work as well, lemme push a fix
Member
|
asking for a second opinion from @mhils: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content-lengthheader fields before setting the expected body lengthcontent-lengthfields when their parsed decimal values differFixes #1316
Tests