Add encode_stray_percents functionality. #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variants, and URL.normalize(). This option (disabled by default, and enabled for normalize), exists to turn unmatched % characters to their encoded equivalent, correcting an otherwise improperly encoded URL. Major browsers don't do this by default, so it's currently limited to the explicit normalize step. Fixes #61.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 97.97% 98.11% +0.14%
==========================================
Files 8 8
Lines 1431 1433 +2
Branches 166 165 -1
==========================================
+ Hits 1402 1406 +4
+ Misses 14 13 -1
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
glyph
approved these changes
Feb 26, 2018
Collaborator
glyph
left a comment
glyph
left a comment
There was a problem hiding this comment.
encode_stray_percents seems somewhat wordy, especially in a portion of the API which has been optimized for brevity.
Could we just call it "percents"?
Otherwise I like this change.
Member
Author
|
@glyph, you got it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #61. This PR adds a new argument to
_percent_decode(), its variants, andURL.normalize().This option (disabled by default, and enabled for normalize), exists to turn unmatched
%characters to their encoded equivalent, correcting an otherwise improperly encoded URL. Major browsers don't do this by default, so it's currently limited to the explicit normalize step.