Skip to content

MOAR BADGERS, er… badges#87

Merged
mahmoud merged 8 commits intomasterfrom
badger-badger-badger
Nov 18, 2019
Merged

MOAR BADGERS, er… badges#87
mahmoud merged 8 commits intomasterfrom
badger-badger-badger

Conversation

@wsanchez
Copy link
Copy Markdown
Contributor

@wsanchez wsanchez commented Nov 8, 2019

No description provided.

@wsanchez wsanchez self-assigned this Nov 8, 2019
@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

requirements.io needs registration

@mahmoud
Copy link
Copy Markdown
Member

mahmoud commented Nov 8, 2019

Hehe, I kind of kept these intentionally minimal and evergreen.

  • Build: All too often I run across a project with some transient travis error that mars the README. Not sure I want to risk that accidentally being our initial impression, right?
  • Coverage: Our coverage is actually pretty high and will only get higher, so why not flaunt it, sure.
  • Requirements: Our install_requires is basically unpinned, so I dunno if this yells about requirements.txt or what, but another one that I'd argue is less of a selling point.
  • PyPI python version compat: Sure! I think we're pretty forward compatible, so my only concern would be this falling out of date and generating concern that we don't support 3.9 or something.

@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

  • Coverage: Our coverage is actually pretty high and will only get higher, so why not flaunt it, sure.

I do like bragging.

  • Build: All too often I run across a project with some transient travis error that mars the README. Not sure I want to risk that accidentally being our initial impression, right?
  • Requirements: Our install_requires is basically unpinned, so I dunno if this yells about requirements.txt or what, but another one that I'd argue is less of a selling point.

These are more for the developers. I go to GitHub pages for projects I work on fairly regularly, and I I see a build badge that's red, I know there's a thing to fix before I go work on some other thing.

The requirements badge will check tox.ini, and serves as a reminder to update the pinned dependencies in there. We pin those for testing stability, but should update them periodically. Requirements.io makes it really easy to identify which need updates.

  • PyPI python version compat: Sure! I think we're pretty forward compatible, so my only concern would be this falling out of date and generating concern that we don't support 3.9 or something.

This one is already on master. :-)

@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

This one is already on master. :-)

No wait, untrue. This uses setup.py IIRC. Hold on.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 8, 2019

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          10       10           
  Lines        1546     1546           
  Branches      177      177           
=======================================
  Hits         1523     1523           
  Misses         12       12           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e19451...7e42f57. Read the comment docs.

@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

We have email for build badge, so I think nixing that is reasonable. I'm a fan of requirements, tho…

@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

Preview here

@wsanchez
Copy link
Copy Markdown
Contributor Author

wsanchez commented Nov 8, 2019

@glyph just provided an example: #88

Copy link
Copy Markdown
Member

@mahmoud mahmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks pretty good at this point, thanks for the badgering! ;D

@mahmoud mahmoud merged commit 7d33145 into master Nov 18, 2019
@wsanchez wsanchez deleted the badger-badger-badger branch November 18, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants