Skip to content

Conversation

@bobsaintcool
Copy link

The ( & ) could be interpreted by the shell when running make

  • Without this patch:
    $ make
    Available targets:
    clean - clean build directory
    test - run unittest
    epydoc - run epydoc to create API documentation
    wininst - Windows installer for Python
    docs - build docs with ReST and Sphinx
    /bin/sh: -c: line 0: syntax error near unexpected token (' /bin/sh: -c: line 0: echo wheel - build wheel binary archive (see pip & wheel)' make: *** [Makefile:10: all] Error 1

  • With this patch:
    $ make
    Available targets:
    clean - clean build directory
    test - run unittest
    epydoc - run epydoc to create API documentation
    wininst - Windows installer for Python
    docs - build docs with ReST and Sphinx
    wheel - build wheel binary archive (see pip & wheel)

The ( & ) could be interpreted by the shell when running make
@bialix
Copy link
Member

bialix commented Jun 13, 2017

Sorry, it took quite a time to review your patch. Thank you for your patch, but unfortunately I reject it. It does not work on Windows and introduces extra single quote characters that Windows command shell does not understand either. So I prefer simply change "&" sign to English word "and".
Thank you anyway.

@bialix bialix closed this Jun 13, 2017
@bobsaintcool
Copy link
Author

Hey,

Thats seems cool!
Sorry for the lake of test on other platforms!

B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants