Use entrypoints for the scripts #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap out `scripts` for entrypoints to ensure executable flag is properly set when installing from wheel, and hashbang is correct for whatever virtualenv/pipenv/etc the user might be user (instead of hardcoded to `/usr/bin/python` and relying on `script` rewrite magic to fix it). Fix a deprecation notice for setup.cfg. _Note: moving `scripts` to `intelhex/scripts` means that the scripts cannot be run as-is from their position in the file system. Recommended approach when developing a package is to `pip install -e .` install in editable mode and work from there._
Collaborator
|
Look good to me, will have to look into side effects regarding our current test and release procedure though before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap out
scriptsfor entrypoints to ensure executable flag is properlyset when installing from wheel, and hashbang is correct for whatever
virtualenv/pipenv/etc the user might be user (instead of hardcoded to
/usr/bin/pythonand relying onscriptrewrite magic to fix it).Fix a deprecation notice for setup.cfg.
Note: moving
scriptstointelhex/scriptsmeans that the scriptscannot be run as-is from their position in the file system. Recommended
approach when developing a package is to
pip install -e .install ineditable mode and work from there.