Skip to content

Fix Error.absolute_path logic #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2014
Merged

Fix Error.absolute_path logic #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee8d27
Fix Error.absolute_path logic
aromanovich Sep 4, 2014
98dc2df
Add tests for fixed Error.absolute_path
aromanovich Sep 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jsonschema/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def absolute_path(self):
return self.relative_path

path = deque(self.relative_path)
path.extendleft(parent.absolute_path)
path.extendleft(reversed(parent.absolute_path))
return path

@property
Expand All @@ -96,7 +96,7 @@ def absolute_schema_path(self):
return self.relative_schema_path

path = deque(self.relative_schema_path)
path.extendleft(parent.absolute_schema_path)
path.extendleft(reversed(parent.absolute_schema_path))
return path

def _set(self, **kwargs):
Expand Down
65 changes: 65 additions & 0 deletions jsonschema/tests/test_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,71 @@ def test_multiple_nesting(self):
self.assertEqual(e5.validator, "minItems")
self.assertEqual(e6.validator, "enum")

def test_recursive(self):
schema = {
"definitions": {
"node": {
"anyOf": [{
"type": "object",
"required": ["name", "children"],
"properties": {
"name": {
"type": "string",
},
"children": {
"type": "object",
"patternProperties": {
"^.*$": {
"$ref": "#/definitions/node",
},
},
},
},
}],
},
},
"type": "object",
"required": ["root"],
"properties": {
"root": {"$ref": "#/definitions/node"},
}
}

instance = {
"root": {
"name": "root",
"children": {
"a": {
"name": "a",
"children": {
"ab": {
"name": "ab",
# missing "children"
}
}
},
},
},
}
validator = Draft4Validator(schema)

e, = validator.iter_errors(instance)
self.assertEqual(e.absolute_path, deque(["root"]))
self.assertEqual(e.absolute_schema_path, deque(['properties', 'root', 'anyOf']))

e1, = e.context
self.assertEqual(e1.absolute_path, deque(['root', 'children', 'a']))
self.assertEqual(e1.absolute_schema_path,
deque(['properties', 'root', 'anyOf', 0, 'properties',
'children', 'patternProperties', '^.*$', 'anyOf']))

e2, = e1.context
self.assertEqual(e2.absolute_path, deque(['root', 'children', 'a', 'children', 'ab']))
self.assertEqual(e2.absolute_schema_path,
deque(['properties', 'root', 'anyOf', 0, 'properties',
'children', 'patternProperties', '^.*$', 'anyOf', 0, 'properties',
'children', 'patternProperties', '^.*$', 'anyOf']))

def test_additionalProperties(self):
instance = {"bar": "bar", "foo": 2}
schema = {
Expand Down