Skip to content

Added methods for error handler registration in Microservice's subclasses. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avara1986 merged 2 commits into from
Nov 29, 2018
Merged

Added methods for error handler registration in Microservice's subclasses. #19

avara1986 merged 2 commits into from
Nov 29, 2018

Conversation

@hcamino
Copy link
Contributor

@hcamino hcamino commented Nov 29, 2018

No description provided.

@hcamino hcamino requested a review from a team November 29, 2018 09:43
@coveralls
Copy link

coveralls commented Nov 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 94

  • 15 of 21 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.063%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyms/flask/app/init.py 15 21 71.43%
Totals Coverage Status
Change from base Build 81: -0.1%
Covered Lines: 406
Relevant Lines: 441
💛 - Coveralls

avara1986
avara1986 reviewed Nov 29, 2018
View reviewed changes
avara1986
avara1986 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@avara1986 avara1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avara1986 avara1986 merged commit f981174 into master Nov 29, 2018
@hcamino hcamino deleted the feature/add_error_handlers branch November 29, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avara1986 avara1986 avara1986 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hcamino @coveralls @avara1986